Skip to content

fix(cap): remove root directory naming convention validation warning#470

Merged
clavery merged 1 commit into
mainfrom
fix/cap-warnings-tweak
Jun 4, 2026
Merged

fix(cap): remove root directory naming convention validation warning#470
clavery merged 1 commit into
mainfrom
fix/cap-warnings-tweak

Conversation

@clavery

@clavery clavery commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Removes the CAP validation warning that flagged a root directory not matching the {id}-v{version} naming convention (e.g. Root directory "commerce-noibu-app-v1.0.0" does not match expected convention "noibu-v1.0.0").

This convention is no longer a valid check, so the warning has been dropped from b2c cap validate (and by extension b2c cap install).

Changes

  • Remove the root-directory naming-convention check in packages/b2c-tooling-sdk/src/operations/cap/validate.ts.
  • Add changeset.

Testing

  • pnpm --filter @salesforce/b2c-tooling-sdk run typecheck:agent — passes
  • pnpm run lint:agent — passes
  • cap validate test suite — all 13 passing

(Note: a pre-existing, unrelated InstanceCommand integration test failure exists on the base branch and is not affected by this change.)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the CAP validation warning that enforced a root directory naming convention ({id}-v{version}), which is no longer a valid requirement. The change updates the local CAP validation logic in the tooling SDK and publishes the behavior change via a patch changeset.

Changes:

  • Removed the root-directory naming convention warning from validateCap() in the CAP validation operation.
  • Added a patch changeset documenting the warning removal for @salesforce/b2c-tooling-sdk.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/b2c-tooling-sdk/src/operations/cap/validate.ts Removes the root directory {id}-v{version} naming convention warning from CAP validation.
.changeset/remove-cap-root-dir-convention-warning.md Adds a patch changeset documenting the CAP validation warning removal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@clavery clavery merged commit c8e0b60 into main Jun 4, 2026
7 checks passed
@clavery clavery deleted the fix/cap-warnings-tweak branch June 4, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants